Updating Create JumpboxVm for Managed Instance#485
Merged
jovanpop-msft merged 15 commits intomicrosoft:masterfrom Nov 11, 2018
Merged
Updating Create JumpboxVm for Managed Instance#485jovanpop-msft merged 15 commits intomicrosoft:masterfrom
jovanpop-msft merged 15 commits intomicrosoft:masterfrom
Conversation
srdan-bozovic-msft
suggested changes
Nov 5, 2018
…uredeploy.json Usign best practice naming conventions from:https://docs.microsoft.com/en-us/azure/architecture/best-practices/naming-conventions#networking
Contributor
|
@jovanpop-msft could you add quota check for Standard BS Family vCPUs using |
|
please unsubscribe
…On Tue, Nov 6, 2018 at 4:43 AM Srđan Božović ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In
samples/manage/azure-sql-db-managed-instance/attach-jumpbox/attachJumpbox.ps1
<#485 (comment)>
:
> $administratorLogin = $parameters['administratorLogin']
$administratorLoginPassword = $parameters['administratorLoginPassword']
$scriptUrlBase = $args[1]
+if($virtualMachineName -eq '')
or $null
------------------------------
In
samples/manage/azure-sql-db-managed-instance/attach-jumpbox/attachJumpbox.ps1
<#485 (comment)>
:
> @@ -157,12 +165,20 @@ SelectSubscriptionId -subscriptionId $subscriptionId
$virtualNetwork = LoadVirtualNetwork -resourceGroupName $resourceGroupName -virtualNetworkName $virtualNetworkName
-$managementSubnetPrefix = CalculateNextAddressPrefix $virtualNetwork 28
+$subnets = $virtualNetwork.Subnets.Name
+If($false -eq $subnets.Contains($managementSubnetName))
this is quick but error prone comparison
------------------------------
In
samples/manage/azure-sql-db-managed-instance/attach-jumpbox/attachJumpbox.ps1
<#485 (comment)>
:
> $administratorLogin = $parameters['administratorLogin']
$administratorLoginPassword = $parameters['administratorLoginPassword']
$scriptUrlBase = $args[1]
+if($virtualMachineName -eq '')
+ $virtualMachineName = 'JumpboxVM'
+
+if($managementSubnetName -eq '')
or $null
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#485 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkkQkRhHm0JXhpLvHkDJf6E9flyUTBbGks5usMYYgaJpZM4YPbxT>
.
--
Regards
Mohamed Shahid V
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.